ref(docker.go): container config fields on Driver no longer pointers #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
4 tasks
carolynvs
reviewed
Apr 23, 2020
There was a problem hiding this comment.
I think that in this case, there was nothing gained by having containerHostCfg and conatinerCfg as pointers. We weren't using it to share data, represent uninitialized data, etc, and were immediately initializing it to an empty struct before calling d.ApplyConfigurationOptions() anyway. 🤷♀️
Signed-off-by: Vaughn Dice <[email protected]>
vdice
force-pushed
the
fix/container-config
branch
from
d7cf37d to
9b6875f
Compare
Signed-off-by: Vaughn Dice <[email protected]>
carolynvs
approved these changes
Apr 27, 2020
| @@ -31,15 +30,15 @@ func TestDriver_GetConfigurationOptions(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Run("configuration options", func(t *testing.T) { | |||
| d.containerCfg = &container.Config{} | |||
| d.containerHostCfg = &container.HostConfig{} | |||
| d := &Driver{} | |||
There was a problem hiding this comment.
💯 this is much cleaner to work with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update config fields on Driver struct to not be pointers
containerCfgandcontainerHostCfg). I started to go down the path of creating methods in this library to return default Driver objects (NewDriver()would return aDriverwith initialized/empty field references) but then I realized perhaps the code simplifications and ease of use that came with switching the fields to be actual values would be warranted here. What do reviewers think? Is there Golang best practice w/r/t fields in structs being pointers? (Avoid? Only use if initializer method(s) are provided?)export ApplyConfigurationOptions
execon the driver in unit tests